fix: Deprecate calling start without a timeout parameter
#364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #238625: iOS - Deprecate init without timeout. |
tanderson-ld
approved these changes
Apr 1, 2024
keelerm84
force-pushed
the
mk/sc-238625/deprecate-init
branch
from
6fa4808
to
78031eb
Compare
mmrj
reviewed
Apr 1, 2024
In addition to this deprecation, calling `start` or `identify` with a timeout value in excess of 15 seconds will result in a warning message being logged.
keelerm84
force-pushed
the
mk/sc-238625/deprecate-init
branch
from
78031eb
to
4c17229
Compare
keelerm84
pushed a commit
that referenced
this pull request
Apr 2, 2024
🤖 I have created a release *beep* *boop* --- ## [9.6.1](9.6.0...9.6.1) (2024-04-02) ### Bug Fixes * Add missing privacy manifest resource for SPM ([#360](#360)) ([48f06cf](48f06cf)) * Add missing privacy tracking fields in manifest ([#362](#362)) ([7439997](7439997)) * Add objective-c binding for `LDConfig.logger` ([#365](#365)) ([eae8d78](eae8d78)) * Deprecate calling `start` without a timeout parameter ([#364](#364)) ([65d88a4](65d88a4)) * Use resource_bundle for privacy manifest in podspec ([#361](#361)) ([971a4c4](971a4c4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <LaunchDarklyReleaseBot@launchdarkly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to this deprecation, calling
startoridentifywith a timeout value in excess of 15 seconds will result in a warning message being logged.