feat: Add initial support for hooks #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
force-pushed
the
mk/sc-239714/add-hooks
branch
2 times, most recently
from
3ac5430
to
947b129
Compare
keelerm84
force-pushed
the
mk/sc-239714/add-hooks
branch
from
947b129
to
65ffac7
Compare
| public typealias EvaluationSeriesData = [String: Any] | ||
|
|
||
| /// Protocol for extending SDK functionality via hooks. | ||
| public protocol Hook { |
There was a problem hiding this comment.
Is this forward compatible? I'm not super familiar with swift protocols.
There was a problem hiding this comment.
Yes. When we add a new method on this protocol, we will need to also provide an extension to that protocol with a default implementation.
| /// Implementation specific hook data for evaluation stages. | ||
| /// | ||
| /// Hook implementations can use this to store data needed between stages. | ||
| public typealias EvaluationSeriesData = [String: Any] |
There was a problem hiding this comment.
This should be immutable if possible (I read 'possible' as not requiring excessive effort and not being inconvenient for consumption). Is there a simple way to achieve immutability here?
There was a problem hiding this comment.
Dictionaries in Swift are passed by value (but lazily copied). So providing a dictionary to a function is already an immutable operation.
kinyoklion
approved these changes
Apr 29, 2024
tanderson-ld
approved these changes
Apr 29, 2024
keelerm84
added a commit
that referenced
this pull request
May 2, 2024
keelerm84
pushed a commit
that referenced
this pull request
May 2, 2024
🤖 I have created a release *beep* *boop* --- ## [9.7.0](9.6.2...9.7.0) (2024-05-02) ### Features * Add initial support for hooks ([#370](#370)) ([93239fc](93239fc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <LaunchDarklyReleaseBot@launchdarkly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.