Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base64 dependency breaks fuse-box bundler #124

Closed
repl-sean-heintz opened this issue Nov 20, 2018 · 4 comments
Closed

Base64 dependency breaks fuse-box bundler #124

repl-sean-heintz opened this issue Nov 20, 2018 · 4 comments

Comments

@repl-sean-heintz
Copy link

Issue:
We're trying to use the LaunchDarkly client-side SDK in a project which creates a bundle using fuse-box (https://fuse-box.org/). Unfortunately, the SDK does not work with this bundler as it includes the Base64 package which does not comply with the package.json spec for package names (https://docs.npmjs.com/creating-a-package-json-file#required-name-and-version-fields). The spec requires that packages be published under a name that is all lowercase. FuseBox fails to import any packages that don't meet this requirement.

Proposed fix:
Switch to a different base64 library which is published with a valid name.

I'd be happy to open a pull request which fixes this issue.

@eli-darkly
Copy link
Contributor

Thanks for alerting us to this. We'll have a fix out shortly.

eli-darkly added a commit that referenced this issue Nov 22, 2018
replace Base64 dependency with a package that has a lowercase name
@eli-darkly
Copy link
Contributor

Just released v2.7.4 with a fix for this.

@eli-darkly
Copy link
Contributor

Actually... I'm sorry, this may not be ready yet. It looks like there may have been some problem with the release process for v2.7.4 and it may not be usable, in which case we'll have to pull it. We'll do our best to get a replacement version out soon, although this may be delayed due to the holiday.

@eli-darkly eli-darkly reopened this Nov 22, 2018
@eli-darkly
Copy link
Contributor

OK, that turned out to be easy to fix, so the new version to use is 2.7.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants