Properly define the variable. #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is particularly important when running with `--use-strict`
|
Thank you - this fix will go into the next release. We are also looking at ways to avoid similar problems in this codebase in the future. We will probably start using ESLint and/or a transpiler - we have been doing that in the JS SDK for browsers, but not in the Node codebase. |
eli-darkly
approved these changes
Mar 21, 2019
Merged
|
OK, the fix has been released. |
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Oct 23, 2019
Migrate to ES2015 syntax and add linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is particularly important when running with
--use-strict