Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Compilation & Testing On Windows #68

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

brianmichel
Copy link
Contributor

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

I didn't see any related issues.

Describe the solution you've provided

This enables the ability to compile this library on Windows environments that are using Swift. I've chosen to use the recent 5.9 release as it should be a good candidate to base support on for this library. We can probably go older, but I thought we'd start at the most recent release.

Describe alternatives you've considered

N/A

Additional context

I saw that Circle CI is being used, however I don't know of a clean way to install Swift in a Circle CI instance (could probably figure this out), but to ensure that there was some CI running and testing the Windows platform I've added a quick GitHub Action workflow that should also run and provide testing output.

@brianmichel brianmichel requested a review from a team as a code owner September 22, 2023 15:08
@brianmichel
Copy link
Contributor Author

It seems that the contract tests are broken on main as well as the other open PR (#67) so I believe that breakage is unrelated to this PR. Clicking into the Circle CI build I see that tests do in fact still pass for all platforms (outside of the contract tests)

@keelerm84
Copy link
Member

Good morning, and my apologies for not responding sooner!

I want you to know I will try to look at this PR soon and see about getting it merged in. I have some other work I have to attend to this iteration, but I have added a ticket to come back to this early next week.

Tracking internally as sc-218506.

@brianmichel
Copy link
Contributor Author

Thanks @keelerm84!

@keelerm84 keelerm84 requested a review from a team as a code owner October 6, 2023 17:40
@keelerm84
Copy link
Member

@brianmichel just wanted to let you know I haven't forgotten about this. I had some last minute priority shifts which are going to take my attention for a bit.

@brianmichel brianmichel changed the title All Compilation & Testing On Windows Add Compilation & Testing On Windows Oct 11, 2023
@keelerm84
Copy link
Member

Sorry this took so long to review and get resolved. Thank you for your contribution!

@keelerm84 keelerm84 merged commit ac5f18c into launchdarkly:main Oct 23, 2023
2 checks passed
keelerm84 pushed a commit that referenced this pull request May 3, 2024
🤖 I have created a release *beep* *boop*
---


##
[3.2.0](3.1.1...3.2.0)
(2023-12-29)


### Features

* Add Compilation & Testing On Windows
([#68](#68))
([ac5f18c](ac5f18c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: LaunchDarklyReleaseBot <LaunchDarklyReleaseBot@launchdarkly.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants