-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Compilation & Testing On Windows #68
Add Compilation & Testing On Windows #68
Conversation
It seems that the contract tests are broken on |
Good morning, and my apologies for not responding sooner! I want you to know I will try to look at this PR soon and see about getting it merged in. I have some other work I have to attend to this iteration, but I have added a ticket to come back to this early next week. Tracking internally as sc-218506. |
Thanks @keelerm84! |
@brianmichel just wanted to let you know I haven't forgotten about this. I had some last minute priority shifts which are going to take my attention for a bit. |
Sorry this took so long to review and get resolved. Thank you for your contribution! |
🤖 I have created a release *beep* *boop* --- ## [3.2.0](3.1.1...3.2.0) (2023-12-29) ### Features * Add Compilation & Testing On Windows ([#68](#68)) ([ac5f18c](ac5f18c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <LaunchDarklyReleaseBot@launchdarkly.com>
Requirements
Related issues
I didn't see any related issues.
Describe the solution you've provided
This enables the ability to compile this library on Windows environments that are using Swift. I've chosen to use the recent 5.9 release as it should be a good candidate to base support on for this library. We can probably go older, but I thought we'd start at the most recent release.
Describe alternatives you've considered
N/A
Additional context
I saw that Circle CI is being used, however I don't know of a clean way to install Swift in a Circle CI instance (could probably figure this out), but to ensure that there was some CI running and testing the Windows platform I've added a quick GitHub Action workflow that should also run and provide testing output.