Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation strings do not work #4

Open
gwleuverink opened this issue Jul 18, 2018 · 3 comments
Open

Translation strings do not work #4

gwleuverink opened this issue Jul 18, 2018 · 3 comments

Comments

@gwleuverink
Copy link

Steps to reproduce:
1: Install Voyager v1.1.3
2: Install bread-templates via Voyager hooks
3: Define a bread with bread template json definitions on some fields
4: View the edit, create or view

In BREAD views that use bread-templates the page translation strings do not work. For example I can see voyager.generic.edit Entity in stead of Edit Entity

In the view the bread-templates use /vendor/bread-templates/resources/views/bread/edit-add.blade.php I see the following line used:

{{ __('voyager.generic.'.(isset($dataTypeContent->id) ? 'edit' : 'add')).' '.$dataType->display_name_singular }}

While in Voyager's original /vendor/tcg/voyager/resources/views/bread/edit-add.blade.php they use:

{{ __('voyager::generic.'.(!is_null($dataTypeContent->getKey()) ? 'edit' : 'add')).' '.$dataType->display_name_singular }}

I could propose a PR for just for the translation strings, but when I do a diff of voyager's edit-add.blade.php and the edit-add.blade.php file of this package I see more things in the original file that have changed since.

Furthermore In the browser console I see the following error:
schermafbeelding 2018-07-18 om 12 32 44

It seems to me the edit-add.blade.php (and possibly the read.blade.phpalso) view need an update to reflect the most recent Voyager version's template markup.

@akazorg
Copy link
Member

akazorg commented Jul 19, 2018

hi @gwleuverink, I will check that bug. Thanks for your message!

@gwleuverink
Copy link
Author

Thank you @akazorg. That is very much appreciated!

@gwleuverink
Copy link
Author

Hi @akazorg, any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants