Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type error: Property 'grey-dark' does not exist on type #5

Closed
fariasmateuss opened this issue Dec 28, 2020 · 0 comments · Fixed by #6
Closed

Type error: Property 'grey-dark' does not exist on type #5

fariasmateuss opened this issue Dec 28, 2020 · 0 comments · Fixed by #6
Assignees
@fariasmateuss
Labels
bug Something isn't working

Comments

@fariasmateuss
Copy link
Contributor

Hi, Laura!

github-explorer/src/pages/Repository/styles.ts

Line 189 in 441b36d

color: ${({ theme }) => theme.colors['grey-dark']};

Is the name of this variable incorrect?!

github-explorer/src/styles/theme.ts

Line 5 in 441b36d

'gray-dark': '#3d3d4d',

This was because there's no typing for the styled components theme and, therefore, the typescript didn't return an error.

I will be sending a PR for correction.
@fariasmateuss fariasmateuss mentioned this issue Dec 28, 2020
Merged
@LauraBeatris LauraBeatris linked a pull request Dec 28, 2020 that will close this issue
Add types to the theme #6
Merged
@LauraBeatris LauraBeatris added the bug Something isn't working label Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fariasmateuss fariasmateuss

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add types to the theme
2 participants
@LauraBeatris @fariasmateuss