Comment section not displaying properly when sorted by Top

[machinator2]

Describe the bug
Comments on some posts display improperly when sorted by top.

Steps to Reproduce

1. Go to this link

Expected behavior
Comments should display with the proper hierarchy, for example when sorted by Hot.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

• Device: Samsung Galaxy A14 5G
• Android: 13
• Sync version: v23.07.27-13:47 (18)

[laurencedawson]

What do you mean properly? Screenshot if possible.

[machinator2]

[spoon247]

Few more examples

https://i.postimg.cc/vTMW7q2Y/Screenshot-20230728-175251-Sync.jpg

https://i.postimg.cc/QCbcfQvp/Screenshot-20230728-175453-Sync.jpg

[chloyster]

Yeah this has been an issue for me too. It seems like when the child comment has more votes than the parent comment is when things get screwy.

[roelhospel]

I've encountered this bug as well

Description

When viewing the comments under a post, and sorting these comments by "top", this causes some odd sorting behaviour.
Comments are seemingly not displayed in the proper order.

I've encountered this bug on the following post: https://lemmy.world/comment/1958306

Steps to reproduce

1. Open the post in the Sync for Lemmy app
2. Sort the comments by Top (via the option in the top right of the app)
3. On the first comment (which in my case was https://lemmy.world/comment/1958306), there is a button to "View more (5)"
4. Click on this button

Observed Behaviour

As shows in the appended screenshots, the comments that show up are completely out of order.
The first comment is immediately 5 levels deep, and has one of the lower scores. Some higher scoring comments are also lower than the lower scoring comments

It's also noteworthy that the "View more (5)" button is above the other comment. I feel like that should be below the other comments

Expected Behaviour

A reaction to a comment should be below that comment, followed by a reaction to a reaction.
When sorting by top, the highest scoring comments should be above the lower scoring comments

Maybe the "View more (5)" button should be below the other comments? This is just my expectation though.

System Specs

Google Pixel 6a, running Android 13
Running version v23.08.01-20:30 (24) of the app

[roelhospel]

Screenshots

[Madbrad200]

Nobody seems to have mentioned it, so I shall add: this also happens to me under "Hot" sorting. "New" sort displays proper parent/child comment relationships, whereas under "Hot" or "Top", child comments are displayed under the wrong parents.

"Old" sort results in 403, which is probably an unrelated issue.

[nalmada]

Nobody seems to have mentioned it, so I shall add: this also happens to me under "Hot" sorting. "New" sort displays proper parent/child comment relationships, whereas under "Hot" or "Top", child comments are displayed under the wrong parents.

"Old" sort results in 403, which is probably an unrelated issue.

depends of the instance

• on lemmy.wold: setting the default sorting to Old results in 403 errors on all posts
• on lemm.ee. setting the default sorting to Old results on "There are no comments" message on all posts

[CMahaff]

Another thread with examples - at time of writing I see misordered comments for Hot, but also Top and New if you click "View More" - https://lemmy.world/post/2615664

Don't know if #233 is a separate issue or related to this issue - my view more is "working" in that it loads comments, but then they are totally in the wrong place for every sort order. See example link above.

[chloyster]

Potentially related PR here

LemmyNet/lemmy#3823

[uniquePWD]

This should be fixed by 0.18.4

[CMahaff]

Unfortunately I'm still seeing some issues, even with instances running 0.18.4.

It's obviously hard to measure - it does seem "better" just browsing a few posts, but still not right.

[uniquePWD]

I'm unsure how it works, but it could require your home instance to be on 0.18.4

[AnneKok]

For me it's the above issue and also replies showing up under the wrong comment / not under their actual parent.

For instance post https://feddit.de/post/2640526

This is what it looks like on Sync for Lemmy on Android with comments sorted by Top (my version in app info is listed as v23.8.12-23:05 (29))

The comment underneath the View More link is a reply to a completely different parent which is shown BELOW it:

Here again some of the comments shown as replies are actually replies to another top-level comment.

[laurencedawson]

Fixed for the next release.