Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warning > request@2.88.2 deprecated #23

Closed
ArtashMardoyan opened this issue Feb 17, 2020 · 3 comments
Closed

warning > request@2.88.2 deprecated #23

ArtashMardoyan opened this issue Feb 17, 2020 · 3 comments

Comments

@ArtashMardoyan
Copy link

warning url-metadata > request@2.88.2: request has been deprecated, see request/request#3142
warning url-metadata > standard > eslint > file-entry-cache > flat-cache > circular-json@0.3.3: CircularJSON is in maintenance only, flatted is its successor.
@laurengarcia
Copy link
Owner

laurengarcia commented Oct 20, 2020 •
edited
Loading

It's a pretty decent sized refactor that needs to happen to remove the request module. The other warning about standard is for the linter (only).

There should be no security or other issues that either of these presents at this time.
Will refactor when time permits, or feel free to send a PR :)
Thanks

@polyrainbow polyrainbow mentioned this issue Feb 13, 2021
Closed
@laurengarcia
Copy link
Owner

TODO: update request module with https://github.com/mikeal/bent

@laurengarcia
Copy link
Owner

Sorry for delay, this should be fixed in version 3.0.1
https://www.npmjs.com/package/url-metadata

Feel free to reopen if you need a backport to version 2.x.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@laurengarcia @ArtashMardoyan