Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop, Mobile: Fix #10292: Email to note address not presented in configuration screen before synchronisation #10293

Merged
merged 2 commits into from Apr 10, 2024

Conversation

pedr
Copy link
Collaborator

@pedr pedr commented Apr 9, 2024

Resolves #10292

Modifying the Joplin Cloud login process to fetch user information just after it is confirmed that the user has valid credentials.

Before this fix if the user accessed Joplin Cloud configuration screen on Desktop or Mobile, before synchronisation but after the login was successful, the email to note field would be empty.

Testing

  • Open Destop or Mobile application without any prior state (you need to delete local files in Desktop or clean app data on Mobile)
  • Connect to Joplin Cloud with a Pro or a Teams account
  • Go to Joplin Cloud screen
  • Email to note field should NOT be empty anymore

@pedr pedr requested a review from laurent22 April 9, 2024 22:56
@laurent22 laurent22 merged commit 859d3e8 into laurent22:dev Apr 10, 2024
10 checks passed
@pedr pedr deleted the etn-fetch-user-info-after-login-desktop branch April 10, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop, Mobile: Email to note address doesn't show in Joplin Cloud tab before the first synchronisation
2 participants