Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile,Desktop: Fixes #10191: Do not invite user to create new notes in the trash folder #10356

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Apr 22, 2024

Summary

This pull request changes the prompt in the trash folder from There are currently no notes. Create one by clicking on the (+) button. to There are no notes in the trash folder. or This subfolder of the trash has no notes..

The new text states "there are no notes in the trash folder" rather than "the trash folder is empty" because it can be shown if only folders are in the trash.

Fixes #10191.

Screenshots

Android

A folder that isn't in the trash:

An empty folder that is in the trash:

An empty trash folder:

Desktop

screenshot: There are no notes in the trash folder banner underneath the search bar
screenshot: This subfolder of the trash has no notes below the search bar and create note/to-do buttons

Testing plan

  1. Create an empty folder and open it.
    • Verify that the There are currently no notes. Create one by clicking on the (+) button. message is shown on mobile and No notes in here. Create one by clicking on "New note". is shown on desktop.
  2. Move the folder to the trash and open it.
    • Verify that the This subfolder of the trash has no notes. message is shown.
  3. Open the trash folder (empty it if there are notes).
    • Verify that the There are no notes in the trash folder. message is shown.

This has been tested successfully on Ubuntu 23.10 and Android 7.

@laurent22 laurent22 merged commit 65c4718 into laurent22:dev Apr 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User should not be invited to create a note from the trash folder
2 participants