Mobile,Desktop: Fixes #10191: Do not invite user to create new notes in the trash folder #10356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request changes the prompt in the trash folder from
There are currently no notes. Create one by clicking on the (+) button.
toThere are no notes in the trash folder.
orThis subfolder of the trash has no notes.
.The new text states "there are no notes in the trash folder" rather than "the trash folder is empty" because it can be shown if only folders are in the trash.
Fixes #10191.
Screenshots
Android
A folder that isn't in the trash:
An empty folder that is in the trash:
An empty trash folder:
Desktop
Testing plan
There are currently no notes. Create one by clicking on the (+) button.
message is shown on mobile andNo notes in here. Create one by clicking on "New note".
is shown on desktop.This subfolder of the trash has no notes.
message is shown.There are no notes in the trash folder.
message is shown.This has been tested successfully on Ubuntu 23.10 and Android 7.