Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table properties are not readable in dark mode #10561

Open
laurent22 opened this issue Jun 10, 2024 · 9 comments
Open

Table properties are not readable in dark mode #10561

laurent22 opened this issue Jun 10, 2024 · 9 comments
Labels
bug It's a bug desktop All desktop platforms editor high High priority issues

Comments

@laurent22
Copy link
Owner

Operating system

Windows

Joplin version

3.0.0

Desktop version info

Table properties in the RTE are not readable in dark mode:

image

Current behaviour

No response

Expected behaviour

No response

Logs

No response

@laurent22 laurent22 added bug It's a bug desktop All desktop platforms editor high High priority issues labels Jun 10, 2024
@needJobCoder
Copy link

can u explain what RTE is ?

@laurent22
Copy link
Owner Author

ChatGPT is your friend here:

image

@skushagra
Copy link

Hello @laurent22, is someone working on this issue? I would like to work on this!

@Aarya01Patil
Copy link

I would like to fix this issue @laurent22

@CodeMaverick2
Copy link

Hey @laurent22 I would like to solve this issue

@Aarya01Patil
Copy link

Hey @personalizedrefrigerator / @laurent22 can you exactly let me know which table property is not readable in dark mode in RTE , because as for the screenshot i can see the properties , did you mean the general tab greys out when we select advanced section and a vice versa
Do you want me to fix that?
It would be helpful for me to know so I can work towards fixing it

@laurent22
Copy link
Owner Author

Hey @personalizedrefrigerator / @laurent22 can you exactly let me know which table property is not readable in dark mode in RTE , because as for the screenshot i can see the properties , did you mean the general tab greys out when we select advanced section and a vice versa

Just try?

@laurent22
Copy link
Owner Author

IMPORTANT: the next person who @-mention someone will be blocked from this repository. If you want to participate in GSoC, start by reading the rule please and one thing you shouldn't do is ping people left and right.

@personalizedrefrigerator
Copy link
Collaborator

did you mean the general tab greys out when we select advanced section and a vice versa

I'm including light and dark mode screenshots for comparison.

light mode screenshot of the table properties dialog
dark mode screenshot of the table properties dialog -- advanced link in the sidebar and show caption checkbox still have the same color as in the light mode screenshot, which is almost invisible.

Based on these, I suspect that the issue is referring to the "show caption" checkbox and "advanced" link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug desktop All desktop platforms editor high High priority issues
Projects
None yet
Development

No branches or pull requests

6 participants