Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block code - kotlin Syntax highlighting and nested comment little problem #1788

Closed
bertuzziclaudio opened this issue Aug 6, 2019 · 7 comments
Labels
upstream There's a problem with upstream code.

Comments

@bertuzziclaudio
Copy link

bertuzziclaudio commented Aug 6, 2019

Environment

Joplin version: 1.0.161
Platform: Only tested on: Linux,Windows,Android
OS specifcs: Windows 10,Android 8.1 , Kubuntu 19.04

/* LEVEL 0
    /*
      multiline nested comment LEVEL 1
    */
    println("on kotlin this is a commented code in comment LEVEL 0")
    /*
        another multiline nested comment LEVEL 1
    */
*/

Describe what you expected to happen:

I espect the block is colorize same as single comment but the line that start with println is colorized as a executable code (sorry for my bad english)

!!! Also in this post the line is wrong colorized as executable

@bertuzziclaudio bertuzziclaudio added the bug It's a bug label Aug 6, 2019
@bertuzziclaudio bertuzziclaudio changed the title Inline code kotlin Inline code - kotlin Syntax highlighting and nested comment little problem Aug 6, 2019
@bertuzziclaudio bertuzziclaudio changed the title Inline code - kotlin Syntax highlighting and nested comment little problem Inline code kotlin Aug 6, 2019
@bertuzziclaudio bertuzziclaudio changed the title Inline code kotlin block code kotlin Syntax highlighting Aug 6, 2019
@bertuzziclaudio bertuzziclaudio changed the title block code kotlin Syntax highlighting block code - kotlin Syntax highlighting and nested comment. Little problem Aug 6, 2019
@bertuzziclaudio bertuzziclaudio changed the title block code - kotlin Syntax highlighting and nested comment. Little problem block code - kotlin Syntax highlighting and nested comment little problem Aug 6, 2019
@tessus tessus added upstream There's a problem with upstream code. and removed bug It's a bug labels Aug 6, 2019
@tessus
Copy link
Collaborator

tessus commented Aug 6, 2019

We are using hightlightjs and this is an upstream issue. Can you please report the issue there?

See https://jsfiddle.net/tessus/u4o1s5ez/

@bertuzziclaudio
Copy link
Author

@tessus
Copy link
Collaborator

tessus commented Aug 6, 2019

Thanks, let's hope they fix it. There have been PRs open for 4-5 years, I don't even want to start with issues.

@tessus
Copy link
Collaborator

tessus commented Aug 12, 2019

@laurent22 I'm not sure, but maybe we should switch to a different highlighter. I have the nagging feeling that the highlightjs project is going down the drain.

@laurent22
Copy link
Owner

@tessus, maybe but not sure anything better and highlight.js is widely used so there's a good chance it will keep being maintained.

@tessus
Copy link
Collaborator

tessus commented Aug 18, 2019

@laurent22 I understand, I just had the feeling that nothing is happening over there. Although they have fixed the nested kotlin comment bug 2 days ago, which seems extremely fast, since there are issues and PRs open that are a few years old.

@tessus
Copy link
Collaborator

tessus commented Aug 18, 2019

Note to self: the fixd should be available in the release that comes after 9.15.9

@lock lock bot locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upstream There's a problem with upstream code.
Projects
None yet
Development

No branches or pull requests

3 participants