fix escaping of title when generating a markdown link #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a title with brackets was escaped incorrectly. The brackets were replaced by underscores. The following title `title [square] (round)` looked like this: [title _square_ _round_](:/c54794f53e5e4b1aa558699e255d5f95) Now it looks like this: [title \[square\] (round)](:/c54794f53e5e4b1aa558699e255d5f95) fixes laurent22#2085
|
@laurent22 Oh, I just noticed that I used my name for the tests. I wrote the tests before the code, so I just used the first thing that came to mind. I can change it to the example I used when I wrote the commit message and description. |
|
As long as the tests are clear, and they are, I'm fine with it, so let's merge. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a title with brackets was escaped incorrectly. The brackets were replaced by underscores.
The following title
title [square] (round)looked like this:Now it looks like this:
fixes #2085