Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fix All notes note list update bugs. #2642

Merged
merged 1 commit into from Mar 15, 2020

Conversation

miciasto
Copy link
Contributor

@miciasto miciasto commented Mar 3, 2020

This PR fixes a couple of small update bugs in the All Notes list. Tests added.

Note list not updated when note is duplicated in All notes

To reproduce:

  1. Create two folders (A and B) with a note N in folder A
  2. Selected folder B in sidebar
  3. Select All notes in sidebar
  4. Duplicate note N

Expected: the new duplicate note appears in the All notes note list
Actual: nothing. The note is duplicated but does not appear.

Note disappears from note list when dragged from All notes to a new parent

To reproduce:

  1. Create two folders (A and B) with a note N in folder A
  2. Select All notes in Sidebar
  3. Drag note N to folder B in sidebar

Expected: the note remains visible in the All notes note list
Actual: the note disappears from the note list.

@miciasto miciasto changed the title Desktop: Fix show-all-notes note list update bugs. Desktop: Fix All notes note list update bugs. Mar 3, 2020
@tessus tessus added the desktop All desktop platforms label Mar 6, 2020
@tessus
Copy link
Collaborator

tessus commented Mar 11, 2020

We should merge this.

@laurent22
Copy link
Owner

Looks good, thanks @mic704b!

@laurent22 laurent22 merged commit 7fb061e into laurent22:master Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop All desktop platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants