Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag creation does not support case preservation (Case preservation is supported for imported tags, however). #2750

Closed
JoshDesmond opened this issue Mar 14, 2020 · 3 comments
Labels
bug It's a bug stale An issue that hasn't been active for a while...

Comments

@JoshDesmond
Copy link

JoshDesmond commented Mar 14, 2020

Note: This issue has been discussed before, but I believe the discussion was left incomplete. References to past discussions are included

Issue:

Tags in Joplin are case insensitive, and I am not suggesting that be changed. However, support for case preservation is inconsistent. When tags are imported, case preservation is supported; and thus, notes with mixed case are supported in Joplin. When a new tag is created or a tag is renamed, however, case preservation is not supported. This discrepancy is unintuitive, and thus warrants "fixing".

Previous Discussion

It appears that case sensitivity was an issue for imported tags sometime ago, and some issues addressed this, along with the problem of case preservation. @laurent22 addressed these concerns, stating,

  • "This is not a bug. In Joplin, tags are case-insensitive, however if they are imported from somewhere else they are left as-is."
  • "Yes there was indeed some issue with the way tags with uppercases were handled. This will be fixed in the next version." (The referenced bug caused by mixed case was indeed fixed).
  • "Case-insensitivity is a feature, not a bug, so that it cannot be changed. If there's a bug related to it though, there might be other ways to fix it."

The issue I'm raising, however, is not about case sensitivity. It is about case preservation, which is a different issue. Case insensitivity should remain, but case preservation should be supported for the creation and renaming of tags.

See

Environment

Joplin version: 1.0.193 (prod, win32)
Platform: Windows
OS specifics: Windows 10 Pro, Version 10.0.18362 Build 18362

Steps to reproduce

1.) I created a new note, and entered the "Add or Remove tags" view for that note. I then type .Test as a new tag name, and the suggestion appears that I create a new tag.
First Image
2.) I accept the option to create a new tag by clicking on the suggestion, and my new tag, ".Test", appears to be accepted with the correct capitalization.
Second Image
3.) Once I exit the tag view for the note, the tag is then converted to lowercase.
Third Image

In the images, however, you'll see that a similar tag is in place which does use capitalization. I managed to get that note by importing from Evernote, suggesting that perhaps there is something unnecessarily converting text to lowercase at the time of tag creation.

Describe what you expected to happen

  • Tags should support mixed case input.
  • Renaming a tag and entering the same text with different casing should update the tag's casing.
  • Two tags with different casing should never exist, or rather, two tags with the same text but different casing should be considered the same tag. (Ensuring this remains true probably involves a few user stories across different platforms, i.e.:
  • If a user tries to create a tag with different casing than an existing tag, it should automatically convert the tag to whatever casing is used in the existing tag.
@JoshDesmond JoshDesmond added the bug It's a bug label Mar 14, 2020
@dpoulton-github
Copy link

In addition to the stated previous GitHub issues something very similar has also previously been raised on the Joplin forum:

https://discourse.joplinapp.org/t/tags-lower-case-only/4220

@stale
Copy link

stale bot commented Apr 28, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Apr 28, 2020
@stale
Copy link

stale bot commented May 6, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed May 6, 2020
@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug It's a bug stale An issue that hasn't been active for a while...
Projects
None yet
Development

No branches or pull requests

2 participants