Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal Lines being rendered in the markdown pane on Solarized Themes #4210

Closed
mtpiercey opened this issue Dec 9, 2020 · 2 comments
Closed

Comments

@mtpiercey
Copy link

Environment

Joplin version: Joplin 1.4.19 (prod, win32)
Platform: Windows
OS specifics: Windows 10 Home 20H2

Revision: de123ee (master)

Steps to reproduce

  1. Use Solarized Light or Solarized Dark them
  2. Create a horizontal line (like with ****, ---, etc.
  3. Notice that line shows up in the markdown editor panel

image

image

image

Same as above but for the Solarized Light theme:
image

Describe what you expected to happen

I don't think this is expected behaviour. On the Solarized Light theme, it shows both the characters used to make the line and the line itself, but I think it only shows the line on the Solarized Dark theme.

AFAIK, it only happens on the Solarized themes. To me it's rather strange (especially on Solarized Dark) since the characters used to make the line are invisible or nearly invisible after the line appears, and me cursor is left on the next line a few characters down.

Maybe this is how it's supposed to go? I personally don't mind the lines themselves in the editor - they do their jobs of separating sections of content. But the characters used to make them disappearing or nearly disappearing is kind of strange.

@mtpiercey mtpiercey added the bug It's a bug label Dec 9, 2020
@CalebJohn
Copy link
Collaborator

If anyone else is seeing this and wishing their theme supported it, you can put the following code in your userchrome.css file

.cm-hr {
  color: transparent !important;
  border-top: 1px solid black; /* Replace black with any color you want */
  display: block;
}

@CalebJohn CalebJohn removed the bug It's a bug label Dec 10, 2020
@mtpiercey
Copy link
Author

Alright, that's actually really cool. I actually like the line, but personally I don't like having the characters disappear.

So it's great to be able to change it like that.

image

I guess I'll close the issue - if anyone else runs into the situation I did, now they have a workaround. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants