Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notes from sub-notebooks not shown when parent notebook selected #517

Closed
x-a-a-d opened this issue May 11, 2018 · 9 comments
Closed

notes from sub-notebooks not shown when parent notebook selected #517

x-a-a-d opened this issue May 11, 2018 · 9 comments

Comments

@x-a-a-d
Copy link

x-a-a-d commented May 11, 2018

Operating system

  • Windows
  • Android

Application

  • Desktop
  • Mobile

When notebook with some sub-notebooks is selected I would expect to see notes from the whole notebooks sub-tree.

@foxmask
Copy link
Contributor

foxmask commented May 11, 2018

For me it is the normal behavior
If you are on sub folder on the filesystem, you dont expect to find all the files of all the sub-dir , do you ?

@tessus
Copy link
Collaborator

tessus commented May 12, 2018

I agree with @foxmask. If all notes are shown anyways why would one use subfolders in the first place?

@x-a-a-d
Copy link
Author

x-a-a-d commented May 12, 2018

I'm not sure we should compare it with the raw filesystem, but even file managers (eg. Total Commander) allow you to display files from the whole subtree and it is quite usefull.

But I agree that it depends on a way how you organize your notes:

  • notes only in "leaf" notebooks => you expect to see whole subtree otherwise you see nothing and it is useless to have notebook tree at all
  • notes also in "node" notebooks => both behaviors make sense

From my point of view the default expected behavior is to display notes from the whole subtree.

@foxmask
Copy link
Contributor

foxmask commented May 12, 2018

I do both, add note on leaf and node, like with Evernote
A thing that could avoid to display notes from sub note, having a possibility to filter the current view of a folder with a lookup .
Today the search field only display results for all folders.

@tessus
Copy link
Collaborator

tessus commented May 12, 2018

I also use notes in nodes and leafs. I still don't understand the usability of it. When you list all notes for a node and its subnodes, the organization goes down the drain.

What do you do, if you have notes with the same name? How are the notes supposed to be listed? In which format? e.g. node/note1, node2/note1, node2/subnode1/note1? In this case you might have very long names at one point. Also, it's starting to look like a filesystem after all.

Technically it's rather easy to achieve, it's just a tree traversal. And there's recursive SQL if the data is in a databse, although I doubt that sqlite has recursive SQL.
But I seriously doubt its usefulness.

@foxmask
Copy link
Contributor

foxmask commented May 12, 2018

Database engines are able to use B-Tree, like postgresql (even SQLite). Also in the chess World, the opening database use trees too. Si it's not a matter of SQL ;)

@tessus
Copy link
Collaborator

tessus commented May 12, 2018

@foxmask I think you misunderstood. to retrieve all notes of a notebook and its subnotebooks, one can use recursive SQL to retrieve the names of the notes. that is, if the filenames are stored in a database and given that the appropriate relations were set as well.

Please note that my SQL comment was only the second part and meant to show off how cool recursive SQL was. The first part was tree traversal.

Btw, I was in DB2 development for many, many years, so I think I know a little bit about databases and different tree algorithms. ;-)

@x-a-a-d
Copy link
Author

x-a-a-d commented May 12, 2018

nice to read the discussion about implementation details of the feature you don't like and don't understand its use case :)

The main use case of selecting whole subtree and not only single node I see when it also behaves as a pre-filter to the search function - currently it doesn't. So we can probably close this issue for now and maybe reopen in the future if the search function is limitted by selected notebook.

@laurent22
Copy link
Owner

Yes it seems it's mostly about filtering the search results (show all notes, or only some of them), which has been requested in another issue.

@lock lock bot locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants