Fix #6126: Some broken context menu options #6422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here and forum, I have fixed this issue now. On inspection I saw this was caused by an unintentional renaming of an object property while refactoring and moving the
resourceInfofunction (resourcePath->filePath).Apart from this fix I have also now added a type to the returned object that was previously marked as
anywhich partially made us miss this detail. I have also added a test to check for valid return type of the above mentioned function.Once again I'm sorry for the carelessness and inconvenience caused by this, due to multiple iterations over the last PR I somehow missed to manually check all options that might have been affected at later stages. Will keep this in mind to always manually test for issues before making final PRs.