Desktop: Fixes #5178: NoteListItem's height can be properly styled using CSS for v2.8+ #6542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ken1kob
force-pushed
the
note-list-item-height-fc
branch
from
af71181
to
21eee8b
Compare
laurent22
reviewed
Jun 7, 2022
Comment on lines
456
to
462
| useEffect(() => { | ||
| const noteItem = Object.values<any>(itemAnchorRefs_.current)[0]?.current; | ||
| const actualItemHeight = noteItem?.getHeight() ?? 0; | ||
| if (actualItemHeight >= 8) { // To avoid generating too many narrow items | ||
| setItemHeight(actualItemHeight); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Please add a comment to explain why this is needed
|
Somebody on discord found a bug in the dev version and I think I've traced it back to this commit.
Size is restored on restart |
|
I can replicate this too |
If you create an issue, I can start working on it. |
|
Sure, just wanted to make you aware in case I had overlooked something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug reported in issue #5178 is fixed.
This PR is the replacement of PR #5271 and is for the refactored NoteList function component in v2.8+.
The following spec is the same with the before, but its implementation is more effecient, because it's based on the efficiency of the React function component.
Specification
When the height of NoteListItem is styled using
userchrome.cssas below, the number of displayed note items is correctly calcurated, and there is no unused dead area in the NoteList panel.By applying this fix, you see what people expects as below shown in issue #5178.