Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't create notes from the terminal with spaces #6930

Closed
jlvcm opened this issue Oct 8, 2022 · 5 comments
Closed

Can't create notes from the terminal with spaces #6930

jlvcm opened this issue Oct 8, 2022 · 5 comments
Labels
bug It's a bug stale An issue that hasn't been active for a while...

Comments

@jlvcm
Copy link

jlvcm commented Oct 8, 2022

Environment

Joplin version: 2.8.8
Platform: Linux
OS specifics: Arch

Steps to reproduce

  1. Open a shell, any shell should work (bash/zsh/fish)
  2. Try to create a note or todo with a space
> joplin mktodo "first second third"
> joplin ls
[ ] first

Describe what you expected to happen

I've tried a bunch of different ways to create a note but i was not able to using the terminal, on the joplin-cli works fine, if i do

:mktodo "first second third"

It gets created correctly as "first second third"

@jlvcm jlvcm added the bug It's a bug label Oct 8, 2022
@laurent22 laurent22 added cli CLI app specific issue high High priority issues labels Oct 9, 2022
@rokaicker
Copy link

@laurent22 Would it be alright if I looked into this? I'm a bit of a novice contributor, but I can see that it's working in v2.8.1 (on Ubuntu), so I can try to figure out what changed between 2.8.8 and 2.8.1 to fix it.

@rokaicker
Copy link

Actually, I tried recreating this issue from the dev branch, but I couldn't recreate it.

(Although I'm not entirely sure if this is the write way to test the cli tool).

image

@jlvcm
Copy link
Author

jlvcm commented Oct 10, 2022

you'r right

  • i've tried dev and it worked fine
  • i've tried the branch for version 2.8.8 and it worked fine
  • i've tried the 2.8.8 build and it worked fine
  • I've even tried my joplin install directly and it worked fine

i think the issue is with the running script from AUR, so probably joplin is fine

https://aur.archlinux.org/cgit/aur.git/tree/joplin.sh?h=joplin
i believe the issue is here ${@}, it should be node main.js "${@}" , after this change it works fine.

thanks for the help!

@laurent22 laurent22 removed cli CLI app specific issue high High priority issues labels Oct 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@github-actions github-actions bot added the stale An issue that hasn't been active for a while... label Nov 9, 2022
@github-actions
Copy link
Contributor

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, feel free to create a new issue with up-to-date information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug stale An issue that hasn't been active for a while...
Projects
None yet
Development

No branches or pull requests

3 participants