Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop/Linux: Running with native Wayland support: Window missing titlebar and close button on GNOME #7442

Open
personalizedrefrigerator opened this issue Dec 12, 2022 · 12 comments
Labels
backlog We'll get to it... eventually... bug It's a bug desktop All desktop platforms linux

Comments

@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Dec 12, 2022

Environment

Joplin version: 2.9.17
Platform: GNOME Desktop
OS specifics: Ubuntu 22.10

Steps to reproduce

  1. Run Joplin with --enable-features=UseOzonePlatform --ozone-platform=wayland command line arguments.

Observed

Joplin lacks a titlebar and window borders and the mouse cursor doesn't follow the system's theme. Additionally, Joplin's icon is the default "no icon" icon: Joplin desktop's icon is a gear symbol.

Describe what you expected to happen

Joplin should have a titlebar, like other applications, The cursor color should follow the system's theme. The Joplin window should have a non-default icon in the task manager.

Logfile

log.txt

Terminal Output

$ ./Joplin-2.9.17.AppImage --enable-features=UseOzonePlatform --ozone-platform=wayland --open-dev-tools --log-level debug
xdg-settings: invalid application name
Try 'xdg-settings --help' for more information.
[9662:1212/124816.145966:ERROR:gpu_init.cc(481)] Passthrough is not supported, GL is egl, ANGLE is 

Screenshot

Screenshot of Joplin desktop. Window lacks a titlebar and close button. The mouse cursor is in light mode.

Reasons to support Wayland natively

  • Touchpad pinch zooming doesn't work with X11 or XWayland.
    • Touchpad pinch zooming is used by some plugins (e.g. js-draw).
  • Application is more likely to scale properly (without blurriness) on high-resolution displays.
@personalizedrefrigerator personalizedrefrigerator added the bug It's a bug label Dec 12, 2022
@personalizedrefrigerator personalizedrefrigerator changed the title Linux/Wayland: Window missing border/close button on GNOME Desktop/Linux: Running with native Wayland support: Window missing titlebar and close button on GNOME Dec 12, 2022
@personalizedrefrigerator
Copy link
Collaborator Author

Some of the above issues might be fixed in a more recent version of Electron.

@laurent22
Copy link
Owner

Can't that be fixed by running the Linux installer? Since it also installs the icons and desktop shortcuts.

@personalizedrefrigerator
Copy link
Collaborator Author

personalizedrefrigerator commented Dec 13, 2022

Can't that be fixed by running the Linux installer? Since it also installs the icons and desktop shortcuts.

I'll test it in a few hours. That should fix the icons, but I don't think it will fix the missing window titlebar.

@personalizedrefrigerator
Copy link
Collaborator Author

Both issues persist after using the install script:
image
The icon is present when I run Joplin with XWayland, however.

@marcelmindemann
Copy link

marcelmindemann commented Dec 14, 2022

As Joplin >= 2.9.1 uses Electron 18, you can try enabling WaylandWindowDecorations like this:

--enable-features=UseOzonePlatform,WaylandWindowDecorations --ozone-platform=wayland

but alas, this results in completely borked window decorations and faulty maximizing with GNOME 42.4 for me.

@github-actions
Copy link
Contributor

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@github-actions github-actions bot added the stale An issue that hasn't been active for a while... label Jan 13, 2023
@laurent22 laurent22 added desktop All desktop platforms linux backlog We'll get to it... eventually... and removed stale An issue that hasn't been active for a while... labels Jan 13, 2023
@miromarszal
Copy link

This is how it looks like for me with WaylandWindowDecorations added. The buttons are not actually working anyway. Also note that there is no icon in the side panel.

image

@nuraiman
Copy link

Based on the comment here: logseq/logseq#5010 , it seems that this issue will be solved upgrading Electron to 19.0.12

@AVAtarMod
Copy link

I can confirm, Joplin-2.12.18.AppImage can start on Wayland seamlessly, without any problems.
Window frame showed correctly, buttons works. See screenshot:
image

@miromarszal
Copy link

I can also confirm it now works for me. However, StartupWMClass is different when launching on Wayland (@joplin/app-desktop instead of Joplin) so the window is not associated with its icon. I had to adjust the .desktop file manually.

@benbaker76
Copy link

benbaker76 commented Oct 11, 2023

Joplin-2.12.18.AppImage does not show the titlebar for me.

$ ~/.joplin/Joplin.AppImage --enable-features=UseOzonePlatform,WaylandWindowDecorations --ozone-platform=wayland

Ubuntu 23.04 with GNOME 44.3

EDIT: Also tried Joplin-2.13.2.AppImage and same issue

@benbaker76
Copy link

Somehow the Joplin window was stuck in fullscreen mode

$ nano ~/.config/Joplin/window-state-prod.json

Set "isFullScreen":false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We'll get to it... eventually... bug It's a bug desktop All desktop platforms linux
Projects
None yet
Development

No branches or pull requests

7 participants