Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two icons in gnome after using ubuntu installer #813

Closed
csemken opened this issue Sep 24, 2018 · 11 comments
Closed

Two icons in gnome after using ubuntu installer #813

csemken opened this issue Sep 24, 2018 · 11 comments
Labels
bug It's a bug linux stale An issue that hasn't been active for a while...

Comments

@csemken
Copy link

csemken commented Sep 24, 2018

Operating system

  • Linux

Application

  • Desktop

Hi, just started using Joplin and I love it!

I just ran into one (very small) problem with the ubuntu installer. It manually creates a gnome shell icon. However, upon running the app you are asked if you want to create one. Clicking yes (and the message comes up every time until you click yes) results in two icons in the shell.

Just deleting the icon created by the ubuntu installer (~/.local/share/applications/joplin.desktop) fixes the issue. So I would suggest taking out the corresponding line in the installer:
echo -e "[Desktop Entry]\nEncoding=UTF-8\nName=Joplin\nExec=/home/$USER/.joplin/Joplin-$version-x86_64.AppImage\nIcon=/home/$USER/.joplin/Icon512.png\nType=Application\nCategories=Application;" >> ~/.local/share/applications/joplin.desktop

--Christoph

@laurent22
Copy link
Owner

Any chance you could create a pull request with the change? (as I'm not familiar with all this) Or maybe @tanrax could help with this?

@tanrax
Copy link
Contributor

tanrax commented Sep 25, 2018

Personally I have had many problems with this automatic icon that is created. When updating it has become orphaned. Hence my contribution and I looked for a native way to integrate it into gnome.
I propose to deactivate it in Linux version and leave the Gnome integration.

@csemken
Copy link
Author

csemken commented Sep 25, 2018

I actually ran into the same issue now. The reason seems to be that – during updates – the AppImage file gets moved to ~/.joplin/Joplin-{version}-x86_64.AppImage.

Maybe there is a way to change the update process, such that the filename stays the same? Or could the gnome-integration feature be altered to create/update a link (e.g. ~/.joplin/Joplin-latest-x86_64.AppImage), so that this link can be used in the joplin.desktop file instead?

Just two ideas I could think of. However, I am afraid I cannot help with implementing them, as I am not at all familiar with React. If they cannot be realised, deactivating the feature seems like a good idea, since it just leads to orphaned icons at the moment (well only after an update, but the default setting is to update automatically).

@laurent22
Copy link
Owner

For information, this particular script doesn't use React, it's just Bash: https://github.com/laurent22/joplin/blob/master/install_ubuntu.sh

If any of you find a good solution, feel free to create a new pull request with a fix.

@tanrax
Copy link
Contributor

tanrax commented Sep 26, 2018

Maintaining the same name could be a solution, maybe.

@13xps
Copy link

13xps commented Oct 5, 2018

I got the same issue running:

wget -O - https://raw.githubusercontent.com/laurent22/joplin/master/Joplin_install_and_update.sh | bash

Ubuntu 18.04
Tested on upgrade, as well as fresh install, still have the same issue.
One icon is slightly blurry, other is perfect.

@tanrax
Copy link
Contributor

tanrax commented Oct 5, 2018

You have to remove the question when you start it. It is who makes the icon of low quality.

@photonxp
Copy link

photonxp commented Oct 14, 2018

Encountered the same problem when I installed 1.0.107-x86 on Ubuntu 16 64bit
Got two icons in the dash search results. One larger, one smaller.
The problem persisted after I upgraded to 1.0.111.

Probably Ubuntu is mysteriously caching the launcher conf file of joplin somewhere (not /usr/share/applications or ~/.local/share/applications). Don't know whether the problem could be solved if the old launcher conf with the bigger icon is deleted. Or wait for Ubuntu to fix it? That would be a long wait ..

@13xps
Copy link

13xps commented Nov 13, 2018

I uninstalled then reinstalled, fixed the issue.

@stale
Copy link

stale bot commented Oct 17, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Oct 17, 2019
@csemken
Copy link
Author

csemken commented Oct 18, 2019

Just updated to the newest version. With the removal of the question at the start the issue is now resolved.

@csemken csemken closed this as completed Oct 18, 2019
@lock lock bot locked and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug It's a bug linux stale An issue that hasn't been active for a while...
Projects
None yet
Development

No branches or pull requests

6 participants