New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop: Resolves #3535: Configure tinymce to handle the first table row as header #8163
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Thank you, that looks very good. The menu we have at the moment is indeed needlessly complex. Regarding |
They were removed previously when inserting the custom table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor issue and we can merge. Thanks for clearing the "any" types!
|
||
// Available table toolbar buttons: | ||
// https://www.tiny.cloud/docs/advanced/available-toolbar-buttons/#tableplugin | ||
const table_toolbar = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tableToolbar (see coding_style.md)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed now. I guess the TinyMCE parameter name confused me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor issue and we can merge. Thanks for clearing the "any" types!
Thanks for implementing this @marph91! |
Resolves #3535
Consider the first table row as header in the richtext editor automatically. Switching isn't needed anymore. This is based on https://tinymce.github.io/tinymce-demos/tables/customizing-the-table-toolbar.html.
Open questions:
any
types. I left them for now, since the surrounding code has them, too. Let me know if I should try to fix them.Screenshot: