Desktop: Fixes #8159: Set minimum search/sort bar width #8249
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
That's a good start, but it needs to work with all languages, and for example it doesn't with French: 
|
There was a problem hiding this comment.
fix: account for lang differences
edit - sorry, meant this to be the commit message. I'm changing the flex-basis property to Md since that is already calculated based on word length to account for language differences. I tested it in 6 different languages and it looks to be fine.
|
Can you include a screenshot of how this looks when using a different layout, e.g. note list on top? |
|
Yes please provide a video. I've just spent 10 minutes testing this and I see no differences. As far as I can see "Md" is not even a valid property so your code is ignored and it reverts back to the previous behaviour. Is this pull request for GSoC or other open source program? |
|
Yes, I just noticed that Md does not work, I'm so sorry about that. Setting it to 50% rather than 60% seems to do the trick though. Issue behavior
Fixed behavior - English
Fixed behavior - French
I'm sorry you wasted your time testing it, I was in the process of fixing it and recording gifs. I can submit another commit. This is not for any program, I am just new to contributing. Thanks for your patience with me. |
|
No problem, and thanks for recording the videos. It indeed looks better and as long as it looks good on the most common languages (those with higher % of translation) that should be fine. |
|
I tried it with German, Spanish, French, and a few others. Seems to work fine. I committed and pushed the change just now. |
|
fixes #8159 |
|
Looks like it's working well. Thanks a lot for fixing this @rio-codes! |
Problem:
When changing the note list panel to a certain width, the search bar becomes so small that it is unusable before flowing to the next line.
Solution:
Change the flex-basis CSS property of the first-row search and sort bar to 60%, rather than auto. This ensures that the search bar will never become too small.