Desktop: Fixes #8591 - Error while quitting the app #8612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertfilho
commented
Aug 3, 2023
| @@ -174,7 +174,7 @@ export default class ElectronAppWrapper { | |||
| // so that it can tell us if we can really close the app or not. | |||
| // Search for "appClose" event for closing logic on renderer side. | |||
| event.preventDefault(); | |||
| this.win_.webContents.send('appClose'); | |||
| if (this.win_) this.win_.webContents.send('appClose'); | |||
There was a problem hiding this comment.
The code inside if (isGoingToExit) is running 3 times after closing the app and at the thirty time this.win_ is null. So, I think in some cases it's entering the next if statement if (!this.rendererProcessQuitReply_) and causing the problem. I hope it makes sense.
|
Looks good, thanks Hubert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By the stack track the error is when trying read webContents from BrowserWindow, and it's happening when the app is about to close. So, after I analysed the code and did some tests I just added a verification in the part of the code when I believe the error is happening. I couldn't reproduce the problem on my machine. I hope it solve the problem.