Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Update Electron to 25.9.0 #9049

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

Fixes at least one security issue (see the Electron release notes).

Testing

  • Linux (Ubuntu 23.04)

    • Launches
    • Can open external editor
    • Can edit with rich text editor
    • Changes light/dark theme to match system
    • Plugins can display dialogs and add markdown renderer content scripts (tested with js-draw)
    • PDF viewer
      • Shows PDF content
      • Print button shows a print dialog
  • Windows 11

    • Launches
    • Installs
    • Sync works (Joplin Server)
    • Can open external editor
    • Can edit with rich text editor
    • Changes light/dark theme to match system
    • Plugins can display dialogs and add markdown renderer content scripts (tested with js-draw)
    • PDF viewer
      • Shows PDF content
      • Print button shows a print dialog

Note:
The second time I launched JoplinPortable on Windows, after installing the Freehand Drawing and RevealJS Integration plugins, an error dialog was shown that referenced ffmpeg. The app still launched and subsequent restarts haven't shown the message.

  • MacOS
    • Launches
    • Sync works (OneDrive)
    • Can open external editor
    • Can edit with rich text editor
    • Changes light/dark theme to match system
    • Plugins can display dialogs and add markdown renderer content scripts (tested with js-draw)
    • PDF viewer
      • Shows PDF content
      • Print button shows a print dialog

@laurent22
Copy link
Owner

Thanks for the update!

@laurent22 laurent22 merged commit f4ee8af into laurent22:release-2.12 Oct 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants