Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #9108: Added Note Properties to Note menu bar items #9119

Merged
merged 1 commit into from Oct 23, 2023

Conversation

CptMeetKat
Copy link
Contributor

@CptMeetKat CptMeetKat commented Oct 23, 2023

Added the 'Note Properties' option to the 'Note' dropdown on the menu bar.

This was already accessible from within the editor; this PR simply introduces an alternative route to access it.

Tests

The 'Note Properties' menu item when a note is selected

image

image

The 'Note Properties' menu item when a note is not selected

image

Fixes #9108

@CptMeetKat CptMeetKat changed the title Added 'Note Properties' to note menu Desktop: Fixes #9108: Added Note Properties to Note menu bar items Oct 23, 2023
@CptMeetKat
Copy link
Contributor Author

The label 'Note Properties' is okay, but let me know if something else is preferred.

@CptMeetKat CptMeetKat marked this pull request as ready for review October 23, 2023 05:03
@laurent22
Copy link
Owner

That's great, thanks. I didn't realise we already had a command for this. The name is fine since it's the same as the dialog, so it means it won't need to be translated.

@laurent22 laurent22 merged commit cd8b538 into laurent22:dev Oct 23, 2023
10 checks passed
@CptMeetKat CptMeetKat deleted the 9108-note-properties-menu-item branch October 24, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Note properties to menu
2 participants