All: Fixes #8561: Fix OneDrive sync crash on throttle #9143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This should fix #8561. The code previously attempted to access headers through
response?.headers?._headers, which seems to not exist.shimusesnodeFetchinternally on desktop and CLI, which documents a.getmethod onresponse.headers. This seems to be equivalent to the browserHeaders.getmethod.Testing
I have not managed to get throttled by OneDrive.
As such, this pull request has only been tested with the included automated test.I have verified that
headers.getworks for a sample request on mobile and desktop.Notes
I'm currently working on extending the existing mobile on-device tests to include a test for
shim.fetch. Ideally all tests would run in CI (and pass) withfsDriverNodeas well.