Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #7547: Fix inserting resources into TinyMCE from plugins (insertText command) #9225

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

Passes options to the markdown renderer for the insertText command that were required for rendering resources.

Fixes #7547.

Testing

This pull request can be tested manually with the following steps:

  1. Open a note with an existing image resource in the markdown editor
  2. Copy the image's markdown (e.g. ![Freehand Drawing.svg](:/0b00b67c9f184b59b9855fd42a70d9e3)).
  3. Switch to a new note
  4. Open the rich text editor
  5. Open the development tools
  6. Run joplin.commandService.execute('insertText', '![Markup for your image here](:/the-uuid-of-your-image-here)')

@laurent22 laurent22 merged commit 1405def into laurent22:dev Nov 7, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop/Plugin API: insertText with an image in the rich text editor changes inserted content
2 participants