Mobile: Fixes #9328: Fix new note/to-do buttons not visible on app startup in some cases

[personalizedrefrigerator]

Summary

Fixes new note/to-do buttons not shown on app startup if "all notes" was the last selected note grouping.

Fixes #9328.

Notes

This pull request adds

diff --git a/packages/app-mobile/root.tsx b/packages/app-mobile/root.tsx
index 5eb8944a2..39cf3d5df 100644
--- a/packages/app-mobile/root.tsx
+++ b/packages/app-mobile/root.tsx
@@ -317,6 +317,7 @@ const appReducer = (state = appDefaultState, action: any) => {
 
 				if ('smartFilterId' in action) {
 					newState.smartFilterId = action.smartFilterId;
+					newState.selectedSmartFilterId = action.smartFilterId;
 					newState.notesParentType = 'SmartFilter';
 				}

I don't think state.smartFilterId is being used anywhere (I think it's always state.selectedSmartFilterId). However, to prevent possible regressions, newState.smartFilterId = ... is not removed.

Testing

1. Click on "All notes" in the notebook sidebar
2. Restart the app
3. Click on the "new note" button and create a new note
4. Press the back button
5. Delete all notebooks
6. Click on "all notes"
7. Verify that the "new note" button isn't shown

This has been successfully tested on Android 7.

[personalizedrefrigerator]

Suggested change

	newState.smartFilterId = action.smartFilterId;
	newState.selectedSmartFilterId = action.smartFilterId;
	newState.selectedSmartFilterId = action.smartFilterId;

A follow-up pull request (not targeting the 2.13 branch) should remove newState.smartFilterId = ....

[laurent22]

I think you can use the activeFolderId setting here, which would be the last selected folder

[personalizedrefrigerator]

The source of the missing note button issue seems to be that activeFolderId is either '' or null on startup when opening the "all notes" screen. The note screen previously only showed the floating action button if activeFolderId or selectedFolderId were not falsey.