Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: #9361: Fix to-dos options toggle don't toggle a rerender in #9364

Merged
merged 1 commit into from Nov 24, 2023

Conversation

pedr
Copy link
Collaborator

@pedr pedr commented Nov 24, 2023

Fixes #9361

The current behavior of the Notes component wouldn't rerender when showCompletedTodos or uncompletedTodosOnTop prop changed value.

I'm wasn't sure what should be the target for this PR, so I pointed to dev, but the branch was created on release-v2.13 or dbb354ad107cbd8c10fee718437f8adabcfdeaeb commit

Testing

  • Created 3 to-dos notes
  • Mark one as complete
  • In the sort-by menu select "Uncompleted to-dos on top". The to-do that is complete should drop to the end of the list
  • In the sort-by menu select "Showcompleted to-dos". The to-do that is complete should disappear from the list.

@pedr pedr added bug It's a bug mobile All mobile platforms v2.13 labels Nov 24, 2023
@pedr pedr requested a review from laurent22 November 24, 2023 00:14
@pedr pedr self-assigned this Nov 24, 2023
@laurent22 laurent22 changed the base branch from dev to release-2.13 November 24, 2023 12:56
@laurent22 laurent22 merged commit 24ed5bd into laurent22:release-2.13 Nov 24, 2023
10 checks passed
@pedr pedr deleted the fix-todo-toggle-mobile branch November 26, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug mobile All mobile platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Show completed to-dos" has no effect until I click on "Reverse sort order"
2 participants