Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Fixes #9374: Fix tooltips don't disappear on some devices (upgrade to js-draw 1.13.2) #9401

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Nov 27, 2023

Summary

  • Upgrades to js-draw 1.13.2 (from 1.11.2)
    • Among other changes: Uses pointerenter and pointerleave to detect hover and long presses (rather than :active and :hover CSS classes)

Fixes #9374.

Notes

There still seems to be an issue with tooltips and a stylus on Android:

  • Moving the stylus near the screen (over a button with a tooltip) causes the tooltip to appear (as expected)
  • Moving the stylus away from the screen while still over the button (or off the edge of the screen, if the button is on the edge of the screen) keeps the tooltip visible until the pen is brought near the screen again.

(Logging events to the console, I see that moving the stylus away from the screen doesn't produce a pointerleave event.)

Testing plan

  1. Open the image editor
  2. Open a tooltip by long-pressing
  3. Open another tooltip by long-pressing
  4. Open a tooltip by opening the menu for a tool
  5. Draw something
  6. Attach an image
  7. Save

This has been successfully tested on an Android 13 device.

@personalizedrefrigerator personalizedrefrigerator changed the base branch from dev to release-2.13 November 27, 2023 22:09
@personalizedrefrigerator personalizedrefrigerator changed the title Mobile: Fixes #9374: Fix tooltips don't disappear on some devices (upgrade to js-draw 1.13.1) Mobile: Fixes #9374: Fix tooltips don't disappear on some devices (upgrade to js-draw 1.13.2) Nov 28, 2023
@laurent22 laurent22 merged commit b1c8cb5 into laurent22:release-2.13 Nov 29, 2023
10 checks passed
laurent22 pushed a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip doesn't disappear
2 participants