Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Fixes #9532: Fix cursor location on opening the editor and attachments inserted in wrong location #9536

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Dec 16, 2023

Summary

Fixes two regressions:

The underlying cause was a type-related issue that caused the selection to not actually be saved (saving undefined instead).

Note

This is a version of #9533, rebased on release-2.13.

Testing

  1. Create a new note with a large amount of content
  2. Scroll to the middle of the note
  3. Attach a drawing
  4. Close and re-open the editor

After step 4, the editor should be scrolled to roughly its original location and the drawing should be attached where the cursor was previously.

This has been tested on an Android 7 device.

A previous version of this pull request (based on dev) was tested on an iOS 17 device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants