Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #9543: Fix nested tables not preserved in rich text editor #9579

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Dec 21, 2023

Summary

Note

Because this was a feature advertised in the release notes, this feature targets the release-2.13 branch.

The turndown.keep function is only applied after all normal rules (added with .add) don't match.

As such, filter for the table rule needed to be modified to return false in the cases where we want to preserve tables.

Fixes #9543.

Testing

  1. Create a note in the rich text editor
  2. Add a table (2x3)
  3. Add a table within that table
  4. Add text within the subtable
  5. Switch to the markdown editor and verify that both tables are preserved

Tested on Ubuntu 23.10.

@personalizedrefrigerator personalizedrefrigerator changed the title Desktop: Fixes #9543: Fix nested tables not preserved Desktop: Fixes #9543: Fix nested tables not preserved in rich text editor Dec 21, 2023
@laurent22
Copy link
Owner

Thanks for the fix!

@laurent22 laurent22 merged commit 144ec1e into laurent22:release-2.13 Dec 22, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants