Desktop: Fixes #9613: Fix rich text editor deletes HTML links to notes #9624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This only fixes #9613 in HTML notes. It is still an issue in markdown notes.
Partially fixes #9613.
Notes
<a href=":/2cdf0b7c25124dda92421d7a839c21be">Test</a>
has itshref
changed tojoplin://2cdf0b7c25124dda92421d7a839c21be
.joplin://2cdf0b7c25124dda92421d7a839c21be
link is still clickable (so seems to be a minor issue).convert_urls: false
to the TinyMCE configuration object also seems to fix the issue in markdown notes. However, this change could lead to regressions (e.g. with pasting from the internet) and is thus best left for a separate pull request (not to be backported intorelease-2.13
).Related: #9647.
Testing
This has been successfully tested on Ubuntu 23.10.