Mobile: Add support for showing only lines of log that contain a filter #9728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+78
to
+80
| if (this.props.navigation.state.defaultFilter) { | ||
| this.setState({ filter: this.props.navigation.state.defaultFilter }); | ||
| } |
There was a problem hiding this comment.
This isn't used by this pull request — it's used by the mobile plugins pull request to show all logs that contain a specific plugin ID.
personalizedrefrigerator
changed the title
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for showing only log entries matching a specific filter (e.g. a plugin ID).
This pull request is intended to support #9652 (mobile plugins).
Screenshot
Above, clicking the search icon shows/hides the "Filter" input. Typing in the filter input updates which log statements are shown (only log statements that contain the filter text somewhere are shown).
Testing
testThis has been successfully tested on Android 7.