Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Hide advanced settings by default #9730

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Jan 15, 2024

Summary

Hides advanced settings by default on mobile.

This is related to #9652:

  • We may not want to display the "load plugin from file" button by default.
  • Currently, the "load from file" button is directly below "Search"

Screen recording

out.mp4

Testing

  1. Open settings
  2. Open "synchronization"
  3. Show advanced settings
  4. Hide advanced settings
  5. Search for "sync" and click "show advanced settings"

This has been manually tested on Android 7.

Notes

  • react-native-paper is used to create a Button (rather than react-native) to simplify adding a "show"/"hide" icon.
    • This gives the button a ripple effect. As other buttons currently don't have this, I think I would rather not have this effect.

@laurent22 laurent22 merged commit 691618b into laurent22:dev Jan 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants