Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Resolves #9819: Allow note viewer to extend to the edge of the screen while pinch zooming #9820

Merged

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Feb 2, 2024

Summary

Fixes #9819 by moving horizontal padding in the note editor from the outside of the webview to the inside.

Screenshots

Not zoomed in:
screenshot: Before and after, shows scrollbars on the very edge of the screen in after, spacing between the edge of the screen and scrollbars in before

Zoomed in:
screenshot: Zoomed in on KaTeX, extends to edge of screen

Testing plan

  1. Create a note with the following text:
# Test

This is a test note that contains text.

## Testing...

**Testing...**

Math that overflows:

$$ e^{i\theta} = \cos \theta + i \sin \theta $$
and thus
$$ \cos (\alpha + \beta) + i \sin (\alpha + \beta) = e^{i(\alpha +\beta)} = e^{i \alpha} + e^{i \beta} = \cos \alpha + i \sin \alpha + \cos \beta + i \sin \beta $$
  1. Verify that there is padding between the note and the edges of the screen
  2. Zoom in
  3. Verify that there is no padding between the zoomed content and the edge of the screen (as is the case in a web browser app).

This has been tested successfully on Android 7 and Android 12.

  • To-do: Test on iOS (in progress)

@laurent22 laurent22 merged commit e83306c into laurent22:dev Feb 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: Content in the note viewer is clipped at the edges of the screen when pinch-zooming
2 participants