Desktop: Fixes #9763: Suppress error that happens during desktop shutdown #9878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9763
Description
The error reported in the issue describes a behavior that seems to happen during the shutdown process from the Desktop app. To prevent the error from happening we are checking if the window object still available, if not we just log a warn message
"The window object was not available during the click event from tray icon"
Testing
To test the behavior I enable the tray icon in the settings and update the code in
ElectronAppWrapperto set thethis.win_to null just after thethis.win_.hide()method is called.After this, if I clicked the tray icon the message should be logged in the terminal.