Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Clipper: Open newly created note opens new window with garbage in Firefox #9951

Closed
bgoodmansf opened this issue Feb 16, 2024 · 12 comments
Closed
Labels
bug It's a bug stale An issue that hasn't been active for a while...

Comments

@bgoodmansf
Copy link

bgoodmansf commented Feb 16, 2024

Operating system

Windows

Joplin version

Web clipper 2.11.2

Desktop version info

No response

Current behaviour

  1. Open Firefox
  2. Click web clipper icon
  3. Click "Clip URL"
  4. Click "Confirm"
  5. Click "Open newly created note"
  6. Firefox opens new window with URL: joplin://x-callback-url/openNote?id=588ee103a214443ebd89d1039b26b762
  7. Firefox window with blank content remains open.

Expected behaviour

Expect browser window to close.

The web clipper properly creates a note in Joplin, but opening the note from the web clipper opens a new window in Firefox with a strange URL. Performing the same sequence in Chrome does not open a new window (or maybe the window is closed so quickly it is not visible).

Logs

No response

@bgoodmansf bgoodmansf added the bug It's a bug label Feb 16, 2024
@graphit0
Copy link

I couldn't reproduce this behaviour

Firefox 124 Nightly
Brave 1.62 Chromium 121
Joplin 2.14.14
Clipper 2.11.2
ubuntu 22.04

  • Firefox opens new window with URL: joplin://x-callback-url/openNote?id=588ee103a214443ebd89d1039b26b762
  • opening the note from the web clipper opens a new window in Firefox with garbage URL

This URL is external link to clipped note and should open dialogue to run Joplin window with created note

Firefox
image
Brave (chromium)
image

Could you be possibly running portable version of Joplin?

@bgoodmansf
Copy link
Author

bgoodmansf commented Feb 16, 2024

I have tried this on both Windows 10, Windows 11 and Fedora 39 with the same result. I am running the non-portable version of Joplin on Windows. Here is a screenshot after clipping a note on Fedora.
Screenshot_20240216_083017

@graphit0
Copy link

Could you report what application is assigned to open joplin:// links

In firefox: General -- Applications
image

@bgoodmansf
Copy link
Author

On Fedora 39, my FIrefox settings looks the same as yours (Use Joplin (default).

Note that the note is opened correctly in Joplin. But the window/tab is left open in Firefox. In Chrome, the window/tab goes away.

@graphit0
Copy link

So the issue here is the tab not closing or there's no warning that you may close the tab afterwards?
Or there's some other expected behaviour?
Gotta clarify that in expected behaviour of original issue.

@bgoodmansf
Copy link
Author

bgoodmansf commented Feb 17, 2024

From the user's perspective, they asked to open a note in Joplin. Instead a tab or window opens in the browser.

I don't know if opening a browser window is a required part of the sequence, but it is definitely not what the user expects. It may be that Chrome also opens a browser window, but it gets closed.

I will add more to the expected behavior.

@graphit0
Copy link

Okay, I can see that now, thanks. Would be nice to update the title as well 👀

@bgoodmansf
Copy link
Author

The title seems correct to me. The problem is that there is window of junk opened in Firefox.

What do you think would be a better description?

@graphit0
Copy link

I see. In my view, opening new tab with external x-callback-url is expected behavior. Joplin uses it to communicate with other applications -- for example you can create a desktop shortcut that would open a particular note using this kind of link.

I believe Joplin expects user to interact with such links, so maybe there's a point of making it somehow more intuitive and easy. That said, I believe x-callback-url is not garbage 😅 (not to mention calling it that might be offensive to people who developed it -- who has main knowledge to fix it)

To keep this particular issue focused on functionality (i.e. not to deal with UX -- without a designer, it's difficult to work on such issues) I suggest the following title

Web Clipper: "Open newly created note" doesn't close its tab after redirect in Firefox

@bgoodmansf
Copy link
Author

I am certain Joplin does NOT expect the user to interact with the tab because it is deleted when using Chrome.

Copy link
Contributor

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@github-actions github-actions bot added the stale An issue that hasn't been active for a while... label Mar 19, 2024
Copy link
Contributor

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, feel free to create a new issue with up-to-date information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug stale An issue that hasn't been active for a while...
Projects
None yet
Development

No branches or pull requests

2 participants