-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web Clipper: Open newly created note opens new window with garbage in Firefox #9951
Comments
I couldn't reproduce this behaviour Firefox 124 Nightly
This URL is external link to clipped note and should open dialogue to run Joplin window with created note Could you be possibly running portable version of Joplin? |
On Fedora 39, my FIrefox settings looks the same as yours (Use Joplin (default). Note that the note is opened correctly in Joplin. But the window/tab is left open in Firefox. In Chrome, the window/tab goes away. |
So the issue here is the tab not closing or there's no warning that you may close the tab afterwards? |
From the user's perspective, they asked to open a note in Joplin. Instead a tab or window opens in the browser. I don't know if opening a browser window is a required part of the sequence, but it is definitely not what the user expects. It may be that Chrome also opens a browser window, but it gets closed. I will add more to the expected behavior. |
Okay, I can see that now, thanks. Would be nice to update the title as well 👀 |
The title seems correct to me. The problem is that there is window of junk opened in Firefox. What do you think would be a better description? |
I see. In my view, opening new tab with external x-callback-url is expected behavior. Joplin uses it to communicate with other applications -- for example you can create a desktop shortcut that would open a particular note using this kind of link. I believe Joplin expects user to interact with such links, so maybe there's a point of making it somehow more intuitive and easy. That said, I believe x-callback-url is not garbage 😅 (not to mention calling it that might be offensive to people who developed it -- who has main knowledge to fix it) To keep this particular issue focused on functionality (i.e. not to deal with UX -- without a designer, it's difficult to work on such issues) I suggest the following title Web Clipper: "Open newly created note" doesn't close its tab after redirect in Firefox |
I am certain Joplin does NOT expect the user to interact with the tab because it is deleted when using Chrome. |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions. |
Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, feel free to create a new issue with up-to-date information. |
Operating system
Windows
Joplin version
Web clipper 2.11.2
Desktop version info
No response
Current behaviour
Expected behaviour
Expect browser window to close.
The web clipper properly creates a note in Joplin, but opening the note from the web clipper opens a new window in Firefox with a strange URL. Performing the same sequence in Chrome does not open a new window (or maybe the window is closed so quickly it is not visible).
Logs
No response
The text was updated successfully, but these errors were encountered: