Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop, Mobile, Cli: Avoid unnecessary requests if credentials are empty #10256

Merged
merged 1 commit into from Apr 3, 2024

Conversation

pedr
Copy link
Collaborator

@pedr pedr commented Apr 3, 2024

There isn't any check right now if the username or password fields were set before checking if the user credentials are valid with a request to the server.

I test the changes in Desktop, Mobile and Cli apps.

Testing

  • Set synchronisation target as Joplin Server on Desktop or Mobile app
  • Let email and/or password field empty
  • Before, when the app would check if the credentials are valid a request would be made to the server, even if the fields were empty
  • Now, if the credentials are empty we can prevent the pointless request

@pedr pedr requested a review from laurent22 April 3, 2024 14:10
@laurent22
Copy link
Owner

That looks good, thanks Pedro!

@laurent22 laurent22 merged commit 1e6cc11 into laurent22:dev Apr 3, 2024
10 checks passed
@pedr pedr deleted the avoid-checking-empty-credentials branch April 3, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants