Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the nREPL server being an Agent was always a private impl detail, fixes gc-405 #15

Merged
merged 1 commit into from Oct 4, 2012

Conversation

cemerick
Copy link
Contributor

@cemerick cemerick commented Oct 3, 2012

@laurentpetit
Copy link
Member

Using the provided snapshot may lead to weird issues with existing installation : in the jar's MANIFEST.MF, the Bundle-Version is already set to 0.2.0.BETA10 which is wrong since it's not the final BETA10.
But one cannot also change it to 0.2.0.BETA10-, because the final release version name, 0.2.0.BET10, will be considered prior to any snapshot version, due to the way OSGi sorts version numbers wrt the qualifier.

laurentpetit added a commit that referenced this pull request Oct 4, 2012
the nREPL server being an Agent was always a private impl detail, fixes gc-405
@laurentpetit laurentpetit merged commit cf1bdc2 into ccw-ide:master Oct 4, 2012
@cemerick
Copy link
Contributor Author

cemerick commented Oct 4, 2012

The plugin.xml just specifies 0.2.0, so any 0.2.0 rev should work, right? I was able to drop it in without a hitch… shrug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants