Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uglified swfobject.js does not behave in same way as original #21

Closed
niciliketo opened this issue Nov 28, 2011 · 1 comment
Closed

Uglified swfobject.js does not behave in same way as original #21

niciliketo opened this issue Nov 28, 2011 · 1 comment

Comments

@niciliketo
Copy link

Hi,

I am using uglifier as part of Rails 3.1 asset pipeline.

I am also using open_flash_chart which includes a version of swfobject.js
https://github.com/pullmonkey/open_flash_chart/blob/e1c826351ab5c1c1370507d8d0b83789807c65a3/assets/javascripts/swfobject.js

After uglfying, the script does not function correctly in IE, although it does in Firefox and Chrome. The problem relates to the function swfobject.embedSWF

Unfortunately, I am not familiar with the inner workings of swfobject.js - so can't give much insight into what is going wrong. Please let me know if I can provide more information.

@lautis
Copy link
Owner

lautis commented Nov 29, 2011

Does it work as epected if you minify the code with raw UglifyJS? If it doesn't, please report this to its issue tracker.

A bit more details about what exactly doesn't work is needed. It'd also help to know what combination of JS runtime and gem for JSONification are you using.

In my apps UglifyJS/Uglifier has worked well with swfobject.embedSWF (swfobject 2.2).

@lautis lautis closed this as completed Apr 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants