Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RefPort's sometimes handled a time step late #204

Closed
2 of 7 tasks
PhilippPlank opened this issue Mar 1, 2022 · 0 comments · Fixed by #205
Closed
2 of 7 tasks

RefPort's sometimes handled a time step late #204

PhilippPlank opened this issue Mar 1, 2022 · 0 comments · Fixed by #205
Assignees
Labels
1-bug Something isn't working area: magma/core Issues with something in lava/magma/core

Comments

@PhilippPlank
Copy link
Contributor

PhilippPlank commented Mar 1, 2022

Objective of issue: Deterministic behavior of when data sent via a RefPort is received by the target process. Occasionally it was possible that the receiving process moved to the next phase before all of its VarPorts got serviced, because sending data via a RefPort does not block. Introducing of a wait() method for RefPorts makes sure that sent data is serviced before the process finishes (which blocks advancing a time step and ensures all VarPorts on the receiving process will be serviced beforehand).

Lava version:

  • 0.3.0 (feature release)
  • 0.2.1 (bug fixes)
  • 0.2.0 (current version)
  • 0.1.2

I'm submitting a ...

  • bug report
  • feature request
  • documentation request

Current behavior:

  • Occasionally it was possible that the receiving process moved to the next phase before all of its VarPorts got serviced, because sending data via a RefPort does not block.

Expected behavior:

  • Introducing of a wait() method for RefPorts makes sure that sent data is serviced before the process finishes (which blocks advancing a time step and ensures all VarPorts on the receiving process will be serviced beforehand).

Steps to reproduce:

  • Run the PilotNet example using Reset process. It occurs when running around 100 samples (~1600 time steps)

Related code:

insert short code snippets here

Other information:

insert the output from lava debug here
@PhilippPlank PhilippPlank self-assigned this Mar 1, 2022
@PhilippPlank PhilippPlank added 1-bug Something isn't working area: magma/core Issues with something in lava/magma/core labels Mar 1, 2022
@PhilippPlank PhilippPlank linked a pull request Mar 1, 2022 that will close this issue
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-bug Something isn't working area: magma/core Issues with something in lava/magma/core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant