Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyProcessBuilder: clean up Ref-/VarPort initialization #59

Closed
PhilippPlank opened this issue Nov 16, 2021 · 0 comments · Fixed by #131
Closed

PyProcessBuilder: clean up Ref-/VarPort initialization #59

PhilippPlank opened this issue Nov 16, 2021 · 0 comments · Fixed by #131
Labels
1-feature New feature request area: magma/compiler Issues with something in lava/magma/compiler
Projects

Comments

@PhilippPlank
Copy link
Contributor

The initialization of RefPorts and VarPorts during build(..) in the PyProcessBuilder expects 2 csp_ports, one receiving and one sending.
Currently there could be a list of csp_ports. This needs to be cleaned up.

Should be done in parallel with Issue #55

Reference:
This is not so elegant and looks like a hack. Normally there could be multiple csp_ports in case of 1:many or many:1 connectivity.
Here there are multiple ports because we've just misused it to pass the different send and recv ports. That's conceptually different. If we throw errors that forbid non 1:1 connections then this will work but we should find a better solution.

Either implement a better way of file a descriptive issue to address this hack and make it cleaner.

Originally posted by @awintel in #46 (comment)

@PhilippPlank PhilippPlank added area: magma/compiler Issues with something in lava/magma/compiler 1-feature New feature request labels Nov 16, 2021
@mgkwill mgkwill added this to the Release v0.2.0 milestone Nov 16, 2021
@awintel awintel modified the milestones: Release v0.2.0, Sprint #16 Nov 22, 2021
@mgkwill mgkwill modified the milestones: -Sprint #16, feature_port Dec 2, 2021
@PhilippPlank PhilippPlank added this to Medium Priority in lava Dec 2, 2021
@PhilippPlank PhilippPlank linked a pull request Feb 10, 2022 that will close this issue
lava automation moved this from Less import | Urgent to Done Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-feature New feature request area: magma/compiler Issues with something in lava/magma/compiler
Projects
lava
Done
Development

Successfully merging a pull request may close this issue.

3 participants