Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document minimum Python version #91

Closed
matham opened this issue Nov 22, 2021 · 5 comments
Closed

Document minimum Python version #91

matham opened this issue Nov 22, 2021 · 5 comments
Assignees
Labels
1-bug Something isn't working integration build, testing, packaging issue
Projects

Comments

@matham
Copy link
Contributor

matham commented Nov 22, 2021

I was trying to install lava on Python 3.7 and ran into a vague syntax error. I understood that it's due to 3.7 not being supported, but it would be nice if the minimum Python version is documented somewhere.

Typically it can be done by adding e.g. python_requires = >=3.8 to setup.cfg and it's maybe listed in the setup metadata!?

@mgkwill mgkwill added integration build, testing, packaging issue reviewed-approved labels Nov 22, 2021
@mgkwill
Copy link
Contributor

mgkwill commented Nov 22, 2021

Thanks. This is a good idea!

@mgkwill
Copy link
Contributor

mgkwill commented Nov 22, 2021

I believe we are all 3.8 or higher.

@PhilippPlank
Copy link
Contributor

It is mentioned in the installing tutorial https://github.com/lava-nc/lava/blob/main/src/lava/tutorials/in_depth/tutorial01_installing_lava.ipynb

But yes, we should add it to the documentation and readme.

@matham
Copy link
Contributor Author

matham commented Nov 23, 2021

I did not see the tutorials. Maybe it should be linked from the readme more prominently?

The benefit of setup.cfg is that pip will refuse to install it for unsupported Python versions, I think. So that if someone tries to install it from pip without reading any docs, they would get a clear error.

@mgkwill mgkwill added the 1-bug Something isn't working label Dec 2, 2021
@mgkwill mgkwill added this to the feature_packaging milestone Dec 2, 2021
@PhilippPlank PhilippPlank added this to To do in lava Dec 2, 2021
@awintel awintel assigned awintel and mgkwill and unassigned awintel Feb 10, 2022
@awintel awintel added this to Uncategorized in lava via automation Feb 10, 2022
@awintel awintel moved this from Uncategorized to Less important | Not urgent in lava Feb 10, 2022
@mgkwill
Copy link
Contributor

mgkwill commented Mar 9, 2022

I've documented minimum python version in the pyproject.toml: https://github.com/lava-nc/lava/blob/main/pyproject.toml#L46

Closing.

Thanks for pointing this out @matham

@mgkwill mgkwill closed this as completed Mar 9, 2022
lava automation moved this from Less important | Not urgent to Done Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-bug Something isn't working integration build, testing, packaging issue
Projects
lava
Done
Development

No branches or pull requests

4 participants