Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom elements are still vulnerable #56

Closed
weizman opened this issue Jan 8, 2023 · 1 comment
Closed

Custom elements are still vulnerable #56

weizman opened this issue Jan 8, 2023 · 1 comment
Labels
vulnerability Introduces snow bypass

Comments

@weizman
Copy link
Member

weizman commented Jan 8, 2023

Snow protection for custom elements that can be extensions for "framable" elements (iframe/frame/object/embed) is not as good as I thought, There are other tricks that can be used there to bypass Snow in a way that is hard to deal with.

Before discovering this, lifecycle callbacks such as the connectedCallback were 2nd in line to Snow, but when applying src to the elements or using other lifecycle callbacks, these callbacks become 1st in line which makes things highly complicated.

Also, when trying to support Firefox #53 both tests from before and after this discovery are vulnerable.

@weizman
Copy link
Member Author

weizman commented Jan 8, 2023

if disallowing extension for "framable" elements (iframe/frame/object/embed) the way Snow does #56 prevents your application from running correctly, please share so in this issue thread so we can discuss the problem and understand how to best deal with it

@weizman weizman closed this as completed Jan 8, 2023
@weizman weizman added the vulnerability Introduces snow bypass label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vulnerability Introduces snow bypass
Projects
None yet
Development

No branches or pull requests

1 participant