Does not work with react 16

[ppong]

I was trying to update our app to the react 16-beta.2 and react knova is running into the following error. Any help would be appreciated.

ERROR in ./~/react-konva/src/react-konva.js
Module not found: Error: Can't resolve 'react/lib/React' in '.../react-konva/src'

ERROR in ./~/react-konva/src/react-konva.js
Module not found: Error: Can't resolve 'react-dom/lib/ReactInstanceMap' in '.../react-konva/src'

ERROR in ./~/react-konva/src/react-konva.js
Module not found: Error: Can't resolve 'react-dom/lib/ReactMultiChild' in '.../react-konva/src'

ERROR in ./~/react-konva/src/react-konva.js
Module not found: Error: Can't resolve 'react-dom/lib/ReactUpdates' in '.../react-konva/src'

[igorrmotta]

got the same issue here...

[igorrmotta]

I guess there is nothing much that can be done. This library is really old and the issue is coming from the way it imports react and react-dom.

var React = require('react/lib/React');

var ReactInstanceMap = require('react-dom/lib/ReactInstanceMap');
var ReactMultiChild = require('react-dom/lib/ReactMultiChild');
var ReactUpdates = require('react-dom/lib/ReactUpdates');

[lavrton]

I will clarify current situation.

react-konva depends on some React private internals. There is no way to implement react-konva with using public API only (actually there is a way, but VERY VERY slow).

I am happy to update react-konva for support of React v16. But v16 has a lot of internal changes (new Fiber reconciler). With v16, we can't use old private API and I don't see a way to use new private API.

But I am tracking status of Fiber API here: facebook/react#9103
As soon as I will have more info, I will update react-konva.

[ppong]

Hey @lavrton, just wondering if you had a chance to take a look at the recently released react v16. Thanks!

[lavrton]

@ppong I am waiting for this issue to be resolved: facebook/react#10758
Then we can update react-konva for react v16.

[ghost]

[ngocdaothanh]

@lavrton facebook/react#10758 has been merged. Can you update react-konva for react v16?

[Flydiverny]

Give him some time, I'm sure he's looking into it when he's available to, as he already expressed that he will. I also figure he'd need some time to figure out and rewrite stuff as react-konva can't depend on no longer existing private internals. Yes, the new reconciler package has been merged. If you are eager to get react-konva have a go at it and make a PR!

[lavrton]

Current status. "React Reconciler Package" PR is merged. But react-reconciler package is not released yet in npm (just empty v0). As soon as it will be released I will start work with it.

Stay tuned and show your love. 🙌

[lavrton]

react-reconciler is released.
Support for v16 is almost finished. All tests are green. 😻
Now I am going to test react-konva with the real app.
Also, I am going to release beta version. So you can test as well.

[programbo]

Great timing!

[mattblackdev]

Excellent! Now I can resume my plan to take over the world! MUAHAHAHA💥

…

On Fri, Nov 3, 2017 at 1:35 AM, John Lombardo ***@***.***> wrote: Great timing! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#120 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE-A-QzJ_KKOhKE6h8opLCDnR5xY0Njyks5syqYTgaJpZM4Os1Lx> .

[lavrton]

Published beta version. You can try with:

npm install react@16.1.0-beta react-dom@16.1.0-beta react-konva@1.5.5-beta

I am going to make a master release when react v16.1.0 is out.

[samkit]

Awesome work! Thanks.

A small glitch, for some reason on android-chrome onClick is not working. But I am still using react 16.0.0, hope that is not the issue here.

[cesardeazevedo]

@lavrton I just did i try on my project, and everything is working perfectly, thanks for your effort.

[germanow]

@lavrton add konva package in install command

npm install react@16.1.0-beta react-dom@16.1.0-beta react-konva@1.5.5-beta konva

[lavrton]

I made a release 1.6.2. It should work ok with React v16.