Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

componentWillReceiveProps deprecated #10

Closed
getaaron opened this issue Mar 31, 2018 · 3 comments
Closed

componentWillReceiveProps deprecated #10

getaaron opened this issue Mar 31, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@getaaron
Copy link

react-native-picker-select/src/index.js

Lines 36 to 38 in 8d77e8d

componentWillReceiveProps(nextProps) {
// update items if items prop changes
if (!isEqual(this.state.items, nextProps.items)) {

needs to be replaced with getDerivedStateFromProps instead

https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops
https://reactjs.org/docs/react-component.html#static-getderivedstatefromprops
@getaaron
Copy link
Author

@lfkwtz Any updates on this?

@lfkwtz
Copy link
Collaborator

lfkwtz commented Apr 18, 2018

On it

@lfkwtz
Copy link
Collaborator

lfkwtz commented Apr 20, 2018

Closed #13

@lfkwtz lfkwtz closed this as completed Apr 20, 2018
@lfkwtz lfkwtz added the enhancement New feature or request label May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@getaaron @lfkwtz